Improve error message for unresolved expressions #11615
Open
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 高春晖 <[email protected]>
Pankraz76
approved these changes
Jan 8, 2026
| enhanced.append("Failed to collect dependencies"); | ||
|
|
||
| org.eclipse.aether.graph.Dependency root = request.getRoot(); | ||
| if (root != null && root.getArtifact() != null) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (root != null && root.getArtifact() != null) { | |
| return if (root != null && root.getArtifact() != null) ? enhanceDependency() : enhanceDependencies(...); |
could be extracted as dedicated branch/concern to provide cohesion over coupling.
Contributor
There was a problem hiding this comment.
ternary operators are harder to read
Contributor
There was a problem hiding this comment.
when correctly formatted its actually just like code structure below: just with different character.
| } | ||
| } | ||
|
|
||
| for (org.eclipse.aether.graph.Dependency dep : request.getDependencies()) { |
Contributor
There was a problem hiding this comment.
could be extracted as dedicated branch/concern to provide cohesion over coupling.
Suggested change
| for (org.eclipse.aether.graph.Dependency dep : request.getDependencies()) { | |
| return enhanceDependencies(...) |
| } catch (DependencyCollectionException e) { | ||
| throw new DependencyResolverException("Unable to collect dependencies", e); | ||
| String enhancedMessage = enhanceCollectionError(e, collectRequest); | ||
| throw new DependencyResolverException(enhancedMessage, e); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new DependencyResolverException(enhancedMessage, e); | |
| throw new DependencyResolverException(enhanceCollectionError(e, collectRequest), e); |
elharo
approved these changes
Jan 12, 2026
| } catch (DependencyCollectionException e) { | ||
| throw new DependencyResolverException("Unable to collect dependencies", e); | ||
| String enhancedMessage = enhanceCollectionError(e, collectRequest); | ||
| throw new DependencyResolverException(enhancedMessage, e); |
| enhanced.append("Failed to collect dependencies"); | ||
|
|
||
| org.eclipse.aether.graph.Dependency root = request.getRoot(); | ||
| if (root != null && root.getArtifact() != null) { |
Contributor
There was a problem hiding this comment.
ternary operators are harder to read
Adjust if statement formatting to comply with project code style: - Split OR conditions onto separate lines with proper indentation - Ensures consistency with Spotless formatting rules
GaoSSR
force-pushed
the
fix/improve-error-message-issue-10324
branch
from
5867ad5 to
1bafff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10324